Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hackney 2 #243

Closed
wants to merge 12 commits into from
Closed

hackney 2 #243

wants to merge 12 commits into from

Conversation

benoitc
Copy link
Owner

@benoitc benoitc commented Sep 12, 2015

Goals:

  • make the connection process more efficient and faster
  • handle more concurrent requests
  • improve the way we reuse the connections (in view of allowing you to handle the congestion problem more efficiently)
  • fix dual-stack resolution and connection strategy #206

should fix #183 and others

@benoitc benoitc mentioned this pull request Sep 13, 2015
Closed
@benoitc benoitc force-pushed the new_pool branch 2 times, most recently from 2dfcd07 to 769b6ce Compare October 25, 2015 19:06
@benoitc
wip: working pool
4f6cef4 
pool is now working.

- connections are lazily handled
- fix #181
- fix #206
- fix #226
- fix #247
- fix #183

TODO:
-----

- For now HTTP requests don't work. it needs to be linked to the new
  connection system
- unitests needs to be added
- pool metrics
@benoitc
don't quit the connnection loop too early
8362440 
sometimes P1 can quit before P2 or the reverse. Just make sure no connection
process is running before quitting the loop.
@benoitc benoitc changed the title new pool management hackney 2 Oct 25, 2015
benoitc
benoitc reviewed Oct 25, 2015
View reviewed changes
src/socket/hackney_pool.erl
false ->
ok
Limit = case Group of
<<"proxy/">> -> State#state.proxy_limit;
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should match the suffix there. ie. <<"proxy/", _/binary>> . also it should match the socks group.

note: itmay be better instead to pass different limits matching some pattern as an option instead, so different groups limits can directly be handled.

@deadtrickster
Copy link
Contributor

Please note how regenerated readme links are pointing to new_pool branch. maybe you will need to regenerate readme after merge in master.

@benoitc
make sure to launch fallback if P1 comes down
61b9866 
if P1 comes down before the fallback has been triggered make sure to launch
it.
@benoitc
fix hackney_socket:info/0
e2e8bec
@benoitc
makes fallback time shorter
89cac33
@benoitc
Copy link
Owner Author

benoitc commented Oct 26, 2015

@deadtrickster thanks! I will :)

@benoitc
Copy link
Owner Author

benoitc commented Mar 13, 2016

superseded by the new work in master.

@benoitc benoitc closed this Mar 13, 2016
@benoitc benoitc deleted the new_pool branch September 28, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dual-stack resolution and connection strategy Hackney hangs in connect
2 participants
@benoitc @deadtrickster