Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: When updating group keys in a Paas, old groups are not removed #269

Closed
portly-halicore-76 opened this issue Jan 14, 2025 · 0 comments · Fixed by #272
Closed

bug: When updating group keys in a Paas, old groups are not removed #269

portly-halicore-76 opened this issue Jan 14, 2025 · 0 comments · Fixed by #272
Labels
bug Something isn't working

Comments

@portly-halicore-76
Copy link
Contributor

Bug Report

Paas Operator version:

Long time here, at least since v0.8.2

Current behaviour:

When a Paas is updated and it's groupname is changed, the old group will still exist.

Expected behaviour:

Remove the old group when the groupname is changed and it's the last Paas referencing this group.

Relates to #205

Steps to reproduce:

  1. Apply Paas with any groupname
  2. Update that paas' groupname
  3. Check that the group is still there
@portly-halicore-76 portly-halicore-76 added the bug Something isn't working label Jan 14, 2025
portly-halicore-76 added a commit to portly-halicore-76/opr-paas that referenced this issue Jan 14, 2025
@portly-halicore-76
* Regression test for belastingdienst#269
ef9a33b 
Signed-off-by: portly-halicore-76 <[email protected]>
portly-halicore-76 added a commit to portly-halicore-76/opr-paas that referenced this issue Jan 14, 2025
@portly-halicore-76
* Fixes belastingdienst#269
10887ec 
Signed-off-by: portly-halicore-76 <[email protected]>
portly-halicore-76 added a commit to portly-halicore-76/opr-paas that referenced this issue Jan 14, 2025
@portly-halicore-76
* Adds regression tests for belastingdienst#269
047b3d9 
Signed-off-by: portly-halicore-76 <[email protected]>
@portly-halicore-76 portly-halicore-76 mentioned this issue Jan 14, 2025
Closed
9 tasks
portly-halicore-76 added a commit to portly-halicore-76/opr-paas that referenced this issue Jan 14, 2025
@portly-halicore-76
* Adds regression tests for belastingdienst#269
a795b5c 
Signed-off-by: portly-halicore-76 <[email protected]>
portly-halicore-76 added a commit to portly-halicore-76/opr-paas that referenced this issue Jan 14, 2025
@portly-halicore-76
* Adds regression tests for belastingdienst#269
509edda 
Signed-off-by: portly-halicore-76 <[email protected]>
portly-halicore-76 added a commit to portly-halicore-76/opr-paas that referenced this issue Jan 14, 2025
@portly-halicore-76
* Adds regression tests for belastingdienst#269
68b2f89 
Signed-off-by: portly-halicore-76 <[email protected]>
portly-halicore-76 added a commit to portly-halicore-76/opr-paas that referenced this issue Jan 14, 2025
@portly-halicore-76
* Adds regression tests for belastingdienst#269
928b49b 
Signed-off-by: portly-halicore-76 <[email protected]>
portly-halicore-76 added a commit to portly-halicore-76/opr-paas that referenced this issue Jan 14, 2025
@portly-halicore-76
* Fixes belastingdienst#269
675af9c 
Signed-off-by: portly-halicore-76 <[email protected]>
@portly-halicore-76 portly-halicore-76 mentioned this issue Jan 14, 2025
Merged
9 tasks
portly-halicore-76 added a commit to portly-halicore-76/opr-paas that referenced this issue Jan 14, 2025
@portly-halicore-76
* Fixes belastingdienst#269
e1d3a96 
Signed-off-by: portly-halicore-76 <[email protected]>
portly-halicore-76 added a commit to portly-halicore-76/opr-paas that referenced this issue Jan 14, 2025
@portly-halicore-76
* Fixes belastingdienst#269
0d1dd4c 
* Adds regression tests

Signed-off-by: portly-halicore-76 <[email protected]>
portly-halicore-76 added a commit to portly-halicore-76/opr-paas that referenced this issue Jan 14, 2025
@portly-halicore-76
* Fixes belastingdienst#269
b517696 
* Adds regression tests

Signed-off-by: portly-halicore-76 <[email protected]>
portly-halicore-76 added a commit to portly-halicore-76/opr-paas that referenced this issue Jan 14, 2025
@portly-halicore-76
* Fixes belastingdienst#269
0c9e1a8 
* Adds regression tests

Signed-off-by: portly-halicore-76 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove old groups on Paas group spec update portly-halicore-76/opr-paas
1 participant
@portly-halicore-76