reorganize test, attempt fixing missing coverage, implement macos tab…

…le keyboard test

android/tests_backend/widgets/table.py

@@ -94,3 +94,6 @@ def typeface(self):
     @property
     def text_size(self):
         return self._row_view(0).getChildAt(0).getTextSize()
+
+    async def assert_keyboard_navigation(self):
+        pytest.skip("test not implemented for this platform")

cocoa/tests_backend/widgets/base.py

@@ -114,6 +114,8 @@ async def type_character(self, char, modifierFlags=0):
         key_code = {
             "<backspace>": 51,
             "<esc>": 53,
+            "<down>": 125,
+            "<up>": 126,
             " ": 49,
             "\n": 36,
             "a": 0,

cocoa/tests_backend/widgets/table.py

@@ -144,3 +144,29 @@ async def activate_row(self, row):
             delay=0.1,
             clickCount=2,
         )
+
+    async def assert_keyboard_navigation(self):
+        # Insure that the list has keyboard focus
+        self.native_table.window.makeFirstResponder(self.native_table)
+        await self.redraw(f"Table is focused sel {self.native_table.selectedRow}")
+        # Navigate down then up, with a letter then 2 arrow keys.
+        await self.type_character("a")
+        await self.redraw("First row is selected")
+        assert self.native_table.selectedRow == 0
+        await self.type_character("<down>")
+        await self.redraw("Second row is selected")
+        assert self.native_table.selectedRow == 1
+        await self.type_character("<up>")
+        await self.redraw("First row is selected")
+        assert self.native_table.selectedRow == 0
+
+        # Move down 3 rows, with letter, arrow, then letter.
+        await self.type_character("a")
+        await self.redraw("Second row is selected")
+        assert self.native_table.selectedRow == 1
+        await self.type_character("<down>")
+        await self.redraw("Third row is selected")
+        assert self.native_table.selectedRow == 2
+        await self.type_character("a")
+        await self.redraw("Forth row is selected")
+        assert self.native_table.selectedRow == 3

gtk/tests_backend/widgets/table.py

@@ -84,3 +84,6 @@ async def activate_row(self, row):
             Gtk.TreePath(row),
             self.native_table.get_columns()[0],
         )
+
+    async def assert_keyboard_navigation(self):
+        pytest.skip("test not implemented for this platform")

testbed/tests/widgets/test_table.py

@@ -161,26 +161,7 @@ async def test_scroll(widget, probe):
 
 async def test_keyboard_navigation(widget, source, probe):
     """The list can be navigated using a keyboard."""
-    if toga.platform.current_platform != "windows":
-        pytest.skip("test only applies on windows at present")
-    # Focus the list by pressing tab.
-    await probe.type_character("\t")
-
-    # Navigate 2 items down. In this dataset, all items start with "A".
-    await probe.type_character("a")
-    await probe.type_character("a")
-    await probe.redraw("Third row is selected")
-    assert widget.selection == source[2]
-
-    # Select the last item with the end key.
-    await probe.type_character("<end>")
-    await probe.redraw("Last row is selected")
-    assert widget.selection == source[-1]
-
-    # Navigate by 1 item, wrapping around.
-    await probe.type_character("a")
-    await probe.redraw("First row is selected")
-    assert widget.selection == source[0]
+    await probe.assert_keyboard_navigation()
 
 
 async def test_select(widget, probe, source, on_select_handler):

winforms/src/toga_winforms/widgets/table.py

@@ -123,8 +123,11 @@ def winforms_search_for_virtual_item(self, sender, e):
         while True:
             # Either winforms might provide a starting index out of bounds if searching at list borders,
             # or this loop may travel out of bounds itself while searching. In either case, wrap around.
-            if i < 0:
-                i = len(self._data) - 1
+            if i < 0:  # pragma: no cover
+                # This could theoretically happen if this event is fired with a backwards search direction,
+                # however this edgecase should not take place within Toga's intended use of this event.
+                # i = len(self._data) - 1
+                raise NotImplementedError("backwards search unsupported")
             elif i >= len(self._data):
                 i = 0
             if (
@@ -135,8 +138,10 @@ def winforms_search_for_virtual_item(self, sender, e):
             ):
                 found_item = True
                 break
-            if find_previous:
-                i -= 1
+            if find_previous:  # pragma: no cover
+                # Toga does not currently need backwards searching functionality.
+                # i -= 1
+                raise NotImplementedError("backwards search unsupported")
             else:
                 i += 1
             if i == e.StartIndex:

winforms/tests_backend/widgets/table.py

@@ -99,3 +99,23 @@ async def activate_row(self, row):
                 delta=0,
             )
         )
+
+    async def assert_keyboard_navigation(self):
+        # Focus the list by pressing tab.
+        await self.type_character("\t")
+
+        # Navigate 2 items down. In this dataset, all items start with "A".
+        await self.type_character("a")
+        await self.type_character("a")
+        await self.redraw("Third row is selected")
+        assert self.native.Items[2].Selected
+
+        # Select the last item with the end key.
+        await self.type_character("<end>")
+        await self.redraw("Last row is selected")
+        assert self.native.Items[self.row_count - 1].Selected
+
+        # Navigate by 1 item, wrapping around.
+        await self.type_character("a")
+        await self.redraw("First row is selected")
+        assert self.native.Items[0].Selected