Use wheels in tox instead of sdists
#1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This seems to make sense - but to confirm my own understanding: this won't give us any improvement in CI, because we're already using --installpkg with a pre-built wheel. This is entirely an optimization for end-users running tox locally, right?
(To be clear - that's totally worth doing - I just want to make sure I haven't misunderstood what this is doing)
That's correct. |
freakboy3742
approved these changes
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
toxto install Briefcase as a wheel instead of an sdist; it's much faster (although, in fairness, it was already pretty fast).PR Checklist: