Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove timestamp and PID from Android log format #1286

Merged
merged 1 commit into from
May 22, 2023

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented May 22, 2023

This information is rarely helpful, and the added line length makes the log difficult to follow even in a moderately wide terminal.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@mhsmith mhsmith force-pushed the android-log-format branch from f7725a3 to 2a64b5b Compare May 22, 2023 08:37
@mhsmith mhsmith requested a review from freakboy3742 May 22, 2023 18:52
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A possible follow up that occurred to me: using a -v switch to control the amount of logging information that is displayed. For most day-to-day Toga apps, you really only care about I/python.stdout. Controlling the log filter to only show those lines and filter the tag prefix would give a very clean day-to-day log output; but if you turn on -v, you get all the other log lines plus the log prefix (and -vv turns on all the logs, including the ones that we're currently supressing).

@freakboy3742 freakboy3742 merged commit 01a04cd into beeware:main May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants