Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tox to mirror CI and support running tests in parallel #1248

Merged
merged 2 commits into from
Apr 30, 2023

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Apr 29, 2023

Changes

  • Updated the default behavior of tox to better reflect the checks that are run in CI
    • This continues to include testing all Python versions
    • Additionally, coverage, pre-commit, docs-lint, and towncrier-check all run now
    • The best experience will be achieved by running tox p
  • The tests can be run in parallel now
    • Using tox -e py-fast will skip coverage and run tests using as many cores as the machine has
  • Producing coverage reports was broken out in to tox -e coverage
    • To include the HTML report, run tox -e coverage-html
    • To fail if the coverage is too low, run tox -e coverage-fail

Notes

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 force-pushed the xdist-take-2 branch 2 times, most recently from 79b5f30 to 98bcdfe Compare April 29, 2023 18:58
@rmartin16 rmartin16 changed the title Run tox tests in parallel (take 2) Update tox to mirror CI and support running tests in parallel Apr 29, 2023
@rmartin16
Copy link
Member Author

After a lot of rabbit holes, I think this brings tox to a really good position now.

@rmartin16 rmartin16 marked this pull request as ready for review April 29, 2023 21:49
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find a fault here - an awesome collection of speedups, consolidations and UX improvements. Nice work.

@freakboy3742 freakboy3742 merged commit 9c4bcb0 into beeware:main Apr 30, 2023
@rmartin16 rmartin16 deleted the xdist-take-2 branch April 30, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants