Refs #1201: Parallelisation of calls to app signing for macOS #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gning is not guaranteed when parallelization is used
…erarchy and updated tests
…and (b) the grouping occurs in a predicable order.
freakboy3742
approved these changes
May 4, 2023
There was a problem hiding this comment.
Nice work! I've cleaned up a couple of code style issues that were causing a problem with CI, added a test for a failure case that wasn't being caught, and made a small tweak to how progress bars and group sorting are applied - but this is really solid! Thanks for the contribution!
| futures = [] | ||
| progress_bar = self.input.progress_bar() | ||
| task_id = progress_bar.add_task("Signing App", total=len(names)) | ||
| with progress_bar: |
There was a problem hiding this comment.
This creates a new progress bar for every group/folder; there should be a single progress bar that is reused.
| progress_bar = self.input.progress_bar() | ||
| task_id = progress_bar.add_task("Signing App", total=len(names)) | ||
| with progress_bar: | ||
| for path in sorted(names, reverse=True): |
There was a problem hiding this comment.
This sorts the files in folders, but it doesn't guarantee the folders themselves are in reverse order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR speeds up signing of files. I tried building the BeeWare helloworld tutorial app sequentially, and then with the parallelised implementation. The sequential signing took about 10 seconds, while the parallelised one took around 2.4s according to my stopwatch.
PR Checklist:
Discussion needed: What parts of apps require signing to occur in a specific sequence, and if so, should parallelisation occur?
There are comments in the sign_app() function that state:
I am not sure about how strict this requirement is. If it is a strict requirement and lots of things might break because of not signing files in order, writing files sequentially may be the preferred implementation.
I tested my parallelised implementation with the BeeWare helloworld tutorial, which only uses Toga. I have not tested this on larger, more complex apps.
Fixes #1201