SDEV-4811 - load tmb_val from genomeTmb if available. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if "genomeTmb" in content.keys(): | ||
| try: | ||
| tmb_val = float(content.get("genomeTmb")) |
There was a problem hiding this comment.
So we're overriding value from tmburMutationBurden with value from genomeTmb; is that correct?
There was a problem hiding this comment.
The idea was to be able to just give the genomeTmb directly.
Rather than derive it from tmburMutationBurden data that may or may not exist.
…atch tmburMutationBurden details.
…ure/SDEV-4811_match_use_genomeTmb_as_mutation_burden
…eature/SDEV-4811_match_use_genomeTmb_as_mutation_burden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.bcgsc.ca/jira/browse/SDEV-4811
For to remove vardb dependence from gsc_report --template rapid (SDEV-4536),
pori_python needs updates to match to the genomeTmb value.
For backwards compatibility, genomeTmb should be derived from tmburMutationBurden components like previously.