Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/devsu 2602 add observed variant annotations #440

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

elewis2
Copy link
Collaborator

@elewis2 elewis2 commented Mar 24, 2025

Adds table to store annotations (comment field plus json field similar to kbdata, to store table tags etc) on all variant types. Uses same pivot column as kb-matches table.

Updates rapid-report filtering to check for tags in the annotations field before doing other filtering, so that by updating the tag users can move variants to different rapid-report summary tables.

@sshugsc
Copy link
Contributor

sshugsc commented Mar 26, 2025

could you add ticket number to migration file?

@elewis2
Copy link
Collaborator Author

elewis2 commented Mar 26, 2025

could you add ticket number to migration file?

done!

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 77.12418% with 35 lines in your changes missing coverage. Please review.

Project coverage is 77.24%. Comparing base (32f6eff) to head (d448f79).

Files with missing lines Patch % Lines
app/routes/report/observedVariantAnnotations.js 67.60% 23 Missing ⚠️
app/models/reports/observedVariantAnnotations.js 67.64% 9 Missing and 2 partials ⚠️
app/routes/report/variants.js 97.61% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #440      +/-   ##
===========================================
+ Coverage    77.18%   77.24%   +0.06%     
===========================================
  Files          179      181       +2     
  Lines         6135     6281     +146     
  Branches       714      732      +18     
===========================================
+ Hits          4735     4852     +117     
- Misses        1323     1350      +27     
- Partials        77       79       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@elewis2
Copy link
Collaborator Author

elewis2 commented Mar 26, 2025

todo: update includes throughout to get these fields when looking up the variants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants