Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup gdt.c and gdt.h to simplify code #12

Merged
merged 3 commits into from
Mar 16, 2025
Merged

Cleanup gdt.c and gdt.h to simplify code #12

merged 3 commits into from
Mar 16, 2025

Conversation

mpetch
Copy link
Contributor

@mpetch mpetch commented Mar 16, 2025

  • Cleanup gdt.c by removing duplicate code
  • Simplify code to use a union for gdt_entry_t
  • The tss_t structure is missing members and is the wrong size

baponkar
baponkar approved these changes Mar 16, 2025
View reviewed changes
Copy link
Owner

@baponkar baponkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankyou for looking into this and made changes.

@baponkar
Copy link
Owner

Okay

@baponkar
Copy link
Owner

I don't know the problem what is making not merging the branch after multiple numbers of approve.

@baponkar baponkar merged commit 7dfeedc into baponkar:main Mar 16, 2025
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baponkar baponkar baponkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpetch @baponkar