Build(deps-dev): bump @typescript-eslint/eslint-plugin from 2.34.0 to 4.19.0, run [GitHub GitlabCoverage F-Droid Wordpress VisualStudioAppCenter Ore Packagist] #6319
Conversation
![dependabot-preview[bot]](https://avatars.githubusercontent.com/in/2141?s=60&v=4){kind=small}
calebcartwright
changed the title
| camelcase: | ||
| [ | ||
| 'error', | ||
| { | ||
| ignoreDestructuring: true, | ||
| properties: 'never', | ||
| ignoreGlobals: true, | ||
| allow: ['^UNSAFE_'], | ||
| }, | ||
| ] | ||
|
|
There was a problem hiding this comment.
eslint-config-standard applied a lot of configuration to this rule, which had to matched for parity in order to incorporate ignoreDestructuring
calebcartwright
force-pushed
the
dependabot/npm_and_yarn/typescript-eslint/eslint-plugin-4.19.0
branch
from
086804d to
427a38a
Compare
| // eslint-disable-next-line | ||
| // @ts-ignore | ||
| import favicon from '../images/favicon.png' |
There was a problem hiding this comment.
switching to ts-expect-error will satiate eslint, but my editor was going nuts over it (which kinda makes sense given this is a raster file) so elected to just do an inline ignore
|
Decided to try to tackle this because it seemed like it was going to start being a major blocker. That turned out to be an awful decision as this was maddeningly horrifying upgrade 😆 Everything should be good to go now though, and this will obviate the need for #6325 (both the plugin and parser needed to be updated together anyway). Went through this iteratively on a problem-by-problem basis and tried to commit early and often along the way to make it easier to review, so some of the commits have a tiny diff. I think it's probably worth circling back to some of those ts-ignore cases at a later date, but IMO it's not worth blocking the eslint-* upgrades here on trying to plugin a perfect explanatory comment especially given the impact/blocking nature of this upgrade on the gatsby and graphql packages |
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 2.34.0 to 4.19.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.19.0/packages/eslint-plugin) Signed-off-by: dependabot-preview[bot] <[email protected]>
…odule-boundary-types on ts files
calebcartwright
force-pushed
the
dependabot/npm_and_yarn/typescript-eslint/eslint-plugin-4.19.0
branch
from
427a38a to
835f945
Compare
calebcartwright
deleted the
dependabot/npm_and_yarn/typescript-eslint/eslint-plugin-4.19.0
branch
Bumps @typescript-eslint/eslint-plugin from 2.34.0 to 4.19.0.
Release notes
Sourced from
@typescript-eslint/eslint-plugin's releases.... (truncated)
Changelog
Sourced from
@typescript-eslint/eslint-plugin's changelog.... (truncated)
Commits
e823919chore: publish v4.19.07ad343bfix(eslint-plugin): [member-delimiter-style] correct invalid fix for multilin...5cc5d2efeat(eslint-plugin): [unbound-method] improve error message (#3203)0557a43feat(eslint-plugin): [object-curly-spacing] support MappedType (#3176)e3a3ea0fix(eslint-plugin): [promise-function-async] bad fixer with computed and lite...56af989refactor(eslint-plugin): [no-floating-promises] update code to use AST instea...6703df1docs(eslint-plugin): [naming-convention] clarify literal regex notation vs. a...9ed3c50refactor(eslint-plugin): use direct ts type guards instead of tsutils (#3193)3f4e9bechore: publish v4.18.055e1fbafix(eslint-plugin): [explicit-module-boundary-types] fixes #2864 related to f...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in the
.dependabot/config.ymlfile in this repo: