Add new tab completion feature #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Konfekt
reviewed
Nov 20, 2019
| tokens=(${(z)LBUFFER}) | ||
| cmd=${tokens[1]} | ||
|
|
||
| if [[ "$LBUFFER" =~ "^\ *cd$" ]]; then |
There was a problem hiding this comment.
Awesome work, but this regular expression is too restrictive. In particular, it should not check for cd but $ ENHANCD_COMMAND.
There was a problem hiding this comment.
Nice catch!! I'll update those 👍 @Konfekt
Konfekt
reviewed
Nov 20, 2019
|
|
||
| if [[ "$LBUFFER" =~ "^\ *cd$" ]]; then | ||
| zle ${ENHANCD_COMPLETION_DEFAULT:-expand-or-complete} | ||
| elif [ "$cmd" = cd ]; then |
There was a problem hiding this comment.
Same here, it should check for $ENHANCD_COMMAND.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Introduce tab completion by
$ENHANCD_FILTERand it's inspired by changyuheng/zsh-interactive-cdWHY
To fix #87