Add API to create maps at runtime #935
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation of unifying map defs
Now both BtfMap and LegacyMap hold MapDef
✅ Deploy Preview for aya-rs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mergify
bot
added
aya
Maps can be created at runtime, in which case they don't have any ELF info. Split the ELF bits into ElfMapData. This is in preparation of adding MapData::create() to create maps at runtime.
|
I'd be happy to review this when it's ready (if you're seeking review). I was just thinking about implementing this sort of functionality. |
|
+1 super interested in this API! |
|
@alessandrod, this pull request is now in conflict and requires a rebase. |
|
@alessandrod, this pull request is now in conflict and requires a rebase. |
|
@alessandrod, this pull request is now in conflict and requires a rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is