Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update button size if title renderer is changed and ignore size is true #2401

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

rh101
Copy link
Contributor

@rh101 rh101 commented Feb 17, 2025

Describe your changes

Ensure button size is updated with the size of the internal label if Button::_ignoreSize is true.

Issue ticket number and link

#2400

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

@halx99 halx99 added this to the 2.3.3 milestone Feb 17, 2025
@halx99 halx99 linked an issue Feb 17, 2025 that may be closed by this pull request
@halx99 halx99 merged commit 10a9904 into axmolengine:dev Feb 17, 2025
15 checks passed
@rh101 rh101 deleted the button-ignore-size branch February 17, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button size is not updated if new title label is set
2 participants