Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to box cox and TransformedDistribution #349

Merged
merged 1 commit into from
Sep 30, 2019

Conversation

vafl
Copy link
Contributor

@vafl vafl commented Sep 29, 2019

Issue #, if available:

Description of changes:

Some small fixes to boxcox:

  • lb_obs was used with the wrong sign in boxcox. I.e. when the smallest observation is -0.1 you had to set lb_obs=0.1
  • fix broadcasting issue in the condition

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@vafl vafl requested a review from rshyamsundar September 29, 2019 22:31
@vafl vafl merged commit f7ca507 into awslabs:master Sep 30, 2019
@vafl vafl deleted the box_cox_fixes branch September 30, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants