-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: unify using @pytest.mark.flaky(...)
& bump pytest plugins
#3132
test: unify using @pytest.mark.flaky(...)
& bump pytest plugins
#3132
Conversation
switching to |
following suggestion from pytest-dev/pytest#11052 (comment) |
@pytest.mark.flaky(...)
@pytest.mark.flaky(...)
& bump pytest plugins
requirements/requirements-test.txt
Outdated
holidays~=0.9 | ||
matplotlib~=3.6 | ||
holidays >=0.9 | ||
matplotlib >=3.6, <3.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~=3.6
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some problem with it and ~
is conda notation not pip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it’s more general than conda https://packaging.python.org/en/latest/specifications/version-specifiers/#id5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So do you want me to use ~ for all?
@lostella, it seems like seeding tests also help to gain some stability... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Borda I suggest to revert two changes (see inline proposed changes). In general, keeping PRs scoped to a small set of changes makes it easier to review, approve & merge faster
Co-authored-by: Lorenzo Stella <[email protected]>
Co-authored-by: Lorenzo Stella <[email protected]>
@lostella seems all tests are 🟢 |
…slabs#3132) *Issue #, if available:* *Description of changes:* seem that there is mix of few packages and maybe better to use just `pytest` extension By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. **Please tag this pr with at least one of these labels to make our release process faster:** BREAKING, new feature, bug fix, other change, dev setup cc: @lostella --------- Co-authored-by: Lorenzo Stella <[email protected]>
Issue #, if available:
Description of changes:
seem that there is mix of few packages and maybe better to use just
pytest
extensionBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup
cc: @lostella