Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dataclasses requirement #2623

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Conversation

lostella
Copy link
Contributor

@lostella lostella commented Feb 7, 2023

Issue #, if available: Fixes #2622

Description of changes: Since Python 3.7 is required, dataclasses is not needed (it’s standard library).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

@lostella lostella requested a review from jaheba February 7, 2023 20:37
@lostella lostella added the pending v0.12.x backport This contains a fix to be backported to the v0.12.x branch label Feb 7, 2023
@lostella lostella merged commit 66a129e into awslabs:dev Feb 7, 2023
@lostella lostella deleted the remove-dataclasses branch February 7, 2023 21:23
@lostella lostella added the bug fix (one of pr required labels) label Feb 8, 2023
lostella added a commit to lostella/gluonts that referenced this pull request Feb 8, 2023
@lostella lostella mentioned this pull request Feb 8, 2023
lostella added a commit that referenced this pull request Feb 8, 2023
* Fix: torch `PoissonOutput` scaling (#2619)

* Remove `dataclasses` requirement (#2623)

* Fix installation docs, fix typos in docstrings (#2625)

---------

Co-authored-by: Kashif Rasul <[email protected]>
@lostella lostella removed the pending v0.12.x backport This contains a fix to be backported to the v0.12.x branch label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix (one of pr required labels)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "dataclasses" from requirements.
2 participants