Add gluonts.util.safe_extract
#2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostella
added
bug fix
|
Ah! This can be simplified a lot |
|
Can we put this into |
jaheba
reviewed
Jan 30, 2023
lostella
force-pushed
the
safe-extract
branch
from
5824214 to
f19bb61
Compare
jaheba
previously approved these changes
Jan 30, 2023
jaheba
approved these changes
Jan 30, 2023
lostella
added a commit
to lostella/gluonts
that referenced
this pull request
Jan 30, 2023
Co-authored-by: Jasper <[email protected]> Co-authored-by: Lorenzo Stella <[email protected]>
Merged
lostella
added a commit
to lostella/gluonts
that referenced
this pull request
Jan 30, 2023
Co-authored-by: Jasper <[email protected]> Co-authored-by: Lorenzo Stella <[email protected]>
Merged
lostella
added a commit
that referenced
this pull request
Jan 30, 2023
* Fix: avoid automatic device detection via serialized tensors when deserializing. (#2576) * Make itertools Map/Filter dataclasses. (#2579) * serde: Fix encoding of dtypes. (#2586) * Add assertion to split function ensuring valid windows (#2587) * Ensure dtype on feat_time in torch DeepAR. (#2596) * Expose aggregation method in ensemble NBEATS, fix forecast shape (#2598) * Fix version in requirements to comply with stricter setuptools. (#2604) Co-authored-by: Lorenzo Stella <[email protected]> * Add `gluonts.util.safe_extract` (#2606) Co-authored-by: Jasper <[email protected]> Co-authored-by: Lorenzo Stella <[email protected]> * fix requirements further * fix style * remove undesired change --------- Co-authored-by: Shubham Kapoor <[email protected]> Co-authored-by: Jasper <[email protected]> Co-authored-by: MarcelK1102 <[email protected]> Co-authored-by: Lorenzo Stella <[email protected]> Co-authored-by: Jasper <[email protected]>
lostella
removed
the
pending v0.11.x backport
jaheba
reviewed
Jan 31, 2023
| @@ -19,6 +19,7 @@ | |||
| from typing import Any, cast, Dict, List, Optional | |||
| import botocore | |||
| import click | |||
| from gluonts.util import safe_extract | |||
jaheba
pushed a commit
to jaheba/gluon-ts
that referenced
this pull request
Jan 31, 2023
Merged
lostella
added a commit
that referenced
this pull request
Feb 2, 2023
* Add assertion to split function ensuring valid windows (#2587) * Ensure dtype on feat_time in torch DeepAR. (#2596) * Move NPTS back to `gluonts.model` (#2597) * Expose aggregation method in ensemble NBEATS, fix forecast shape (#2598) * Fix bug with static cardinalities in `PandasDataset` (#2599) * Expose `weight_decay` in torch TFT estimator class (#2603) * Fix version in requirements to comply with stricter setuptools. (#2604) Co-authored-by: Lorenzo Stella <[email protected]> * Add `gluonts.util.safe_extract` (#2606) Co-authored-by: Jasper <[email protected]> Co-authored-by: Lorenzo Stella <[email protected]> * Fix incorrect import in `tsbench`, apply latest black (#2613) * Allow ReduceLROnPlateau to track val_loss when validation set is available (#2614) --------- Co-authored-by: MarcelK1102 <[email protected]> Co-authored-by: Jasper <[email protected]> Co-authored-by: Gerald Woo <[email protected]> Co-authored-by: Lorenzo Stella <[email protected]> Co-authored-by: Jasper <[email protected]>
jaheba
pushed a commit
that referenced
this pull request
Feb 6, 2023
* Fix version in requirements to comply with stricter setuptools. (#2604) Co-authored-by: Lorenzo Stella <[email protected]> * Backport: Add gluonts.util.safe_extract (#2606) * Expose aggregation method in ensemble NBEATS, fix forecast shape (#2598) * Disable Py36 tests, fix version. * Fixup. * Cap numpy compatibility in `mxnet` extra requirements (#2506) * xfail multivariate grouper test Co-authored-by: Lorenzo Stella <[email protected]> Co-authored-by: Jasper <[email protected]> --------- Co-authored-by: Lorenzo Stella <[email protected]> Co-authored-by: Lorenzo Stella <[email protected]>
lostella
added
pending v0.9.x backport
and removed
pending v0.10.x backport
lostella
added a commit
to lostella/gluonts
that referenced
this pull request
Feb 15, 2023
Co-authored-by: Jasper <[email protected]> Co-authored-by: Lorenzo Stella <[email protected]>
Merged
lostella
added a commit
that referenced
this pull request
Feb 15, 2023
* Add `gluonts.util.safe_extract` (#2606) Co-authored-by: Jasper <[email protected]> Co-authored-by: Lorenzo Stella <[email protected]> * Fix call to `extractall` (#2648) * remove py36 * fix requirements * fix flake8 * Cap numpy compatibility in `mxnet` extra requirements (#2506) * xfail multivariate grouper test Co-authored-by: Lorenzo Stella <[email protected]> Co-authored-by: Jasper <[email protected]> * roll back undesired change * fixup * remove np.long * fix * fix flake8 --------- Co-authored-by: Jasper <[email protected]> Co-authored-by: Lorenzo Stella <[email protected]> Co-authored-by: Jasper <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: Similar to #2484, add
safe_extractutility to sanitize destination paths before extracting archives.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup