Change SeasonalNaive fallback predictor to nanmean #2549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could this be considered a bugfix? |
|
I would say so. |
lostella
added
bug fix
lostella
approved these changes
Jan 11, 2023
lostella
pushed a commit
to lostella/gluonts
that referenced
this pull request
Jan 17, 2023
Co-authored-by: Abdul Fatir Ansari <[email protected]>
Merged
lostella
added a commit
that referenced
this pull request
Jan 17, 2023
* Update workflow actions to latest versions (#2447) * Simplify setup.py (#2525) * Use Justfile for checks. * Fix dataclass eventual handling. (#2530) * Improve README example (#2538) * Change SeasonalNaive fallback predictor to nanmean (#2549) Co-authored-by: Abdul Fatir Ansari <[email protected]> * Compact PandasDataset string representation (#2558) Co-authored-by: Jasper <[email protected]> Co-authored-by: Lorenzo Stella <[email protected]> * Update `MANIFEST.in`. (#2566) Fixes: #2564 We want to distribute more files in the source distribution, such that GluonTS can be more easily be imported in other distributions, e.g. conda. * Add NaN validation to Evaluator (#2568) Co-authored-by: Jasper <[email protected]> Co-authored-by: Abdul Fatir <[email protected]> Co-authored-by: Abdul Fatir Ansari <[email protected]> Co-authored-by: Lorenzo Stella <[email protected]>
lostella
removed
the
pending v0.11.x backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Changed SeasonalNaive prediction from
meantonanmeanin case time series is shorter than season_length.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup