Remove mypy plugin for dataclass. #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaheba
added
the
pending v0.11.x backport
lostella
approved these changes
Dec 20, 2022
lostella
pushed a commit
to lostella/gluonts
that referenced
this pull request
Jan 2, 2023
Merged
lostella
added a commit
that referenced
this pull request
Jan 3, 2023
* Fix `serde.dataclass` inheritance handling. (#2512) Further simplified impementation. * Fix `QuantileForecast.quantile` in case only mean is stored (#2513) * Remove mypy plugin for dataclass. (#2514) * GH Actions: Use authenticated requests for just. (#2522) * Fix `aggregate_valid` for non-numerical columns (#2526) * Make serde.dataclass always kw-only. (#2428) Co-authored-by: Jasper <[email protected]>
lostella
removed
the
pending v0.11.x backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to tell mypy that
serde.dataclassis adataclassusing the plugin. However, that led to mypy failing (no idea why).The trick is use
TYPE_CHECKINGto makemypyassume thatserde.dataclassis the same asdataclasses.dataclass.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup