Remove serde dump_code/load_code. #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostella
approved these changes
Dec 9, 2022
Comment on lines
1052
to
-1055
| ), f"Code serialization for transformer {t} does not work" | ||
| assert dump_code(x) == dump_code( | ||
| z | ||
| ), f"JSON serialization for transformer {t} does not work" |
There was a problem hiding this comment.
Assertion messages here appeared to be swapped?
There was a problem hiding this comment.
Not sure I understand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to
serde.encodewhich encodes an object into a json-serializable form,serde.dump_codereturns a string which is something like thereprof the object.I don't think there is much value in this, since it's error prone and basically never used. Thus, this PR removes
dump_code.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup