Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for PandasDataset, fix missing assertion #2453

Merged
merged 6 commits into from
Nov 23, 2022

Conversation

lostella
Copy link
Contributor

Description of changes:

  • Add different test cases for PandasDataset being constructed with pd.Series or pd.DataFrame collections
  • Add test util to recursively compare objects
  • Add missing assertion

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

@lostella lostella force-pushed the better-pandas-tests branch from cfb73d6 to 813d428 Compare November 22, 2022 20:31
@lostella lostella added tests This item concerns improving tests bug fix (one of pr required labels) pending v0.11.x backport This contains a fix to be backported to the v0.11.x branch labels Nov 22, 2022
@lostella lostella merged commit 2cd8957 into awslabs:dev Nov 23, 2022
@lostella lostella deleted the better-pandas-tests branch November 23, 2022 10:20
lostella added a commit to lostella/gluonts that referenced this pull request Nov 24, 2022
@lostella lostella mentioned this pull request Nov 24, 2022
lostella added a commit that referenced this pull request Nov 24, 2022
* Add test cases for `PandasDataset`, fix missing assertion (#2453)

* Speed up `PandasDataset` further (#2441)

* Fix MANIFEST.in (#2456)

* fix path for backport in MANIFEST.in
@lostella lostella removed the pending v0.11.x backport This contains a fix to be backported to the v0.11.x branch label Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix (one of pr required labels) tests This item concerns improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants