Enable dropping of columns in dataset.schema.translate. #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
343
to
+349
| def __call__(self, item): | ||
| result = dict(item) | ||
| if self.drop: | ||
| keys = item.keys() - self.get_fields() | ||
| result = {key: item[key] for key in keys} | ||
| else: | ||
| result = dict(item) | ||
|
|
There was a problem hiding this comment.
What is supposed to happen when we call the Translator with drop=True? I could imagine two things:
- Dropping
itemfromfieldsor - returning the
fieldsthat are not present initem
It seems to me like item would be a subset of fields so item.keys() - self.get_fields() would always be empty...
There was a problem hiding this comment.
item is the input, so not sure what you mean with dropping item from fields.
The idea is that if drop is enabled, only those fields are copied to the result which are not selected by some translation.
This is what it does:
t = Translator.parse(a="b", drop=True)
t(
{
"b": 1, # will be removed if `drop` because selected by a
"c": 42, # will remain always
}
)There was a problem hiding this comment.
I see, that makes sense. 👍
Could you add a similar explanation to the docstring, explaining what drop does?
codingWhale13
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup