Fix dominick dataset bug. #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! A bit of a nitpick, but the title should be in present tense and also has a |
|
Done :) |
jaheba
previously approved these changes
Oct 11, 2022
| @@ -238,7 +238,7 @@ def default_prediction_length_from_frequency(freq: str) -> int: | |||
| "T": 60, | |||
| "H": 48, | |||
| "D": 30, | |||
| "W": 8, | |||
| "W-SUN": 8, | |||
There was a problem hiding this comment.
This fix doesn't specific to dominick, but be an issue with the canonical name of the weekly frequency.
Otherwise looks good to me.
There was a problem hiding this comment.
Yes, I was trying to find out which other dataset it affects, but there aren't many dataset. I think it comes from a specific condition arising out of the Dominick dataset. I marked it as Dominick, because yesterday, I encountered issue because of it.
There was a problem hiding this comment.
Should W-SUN be added along with W, instead of replacing?
There was a problem hiding this comment.
Yes. I think that would be better. :)
There was a problem hiding this comment.
No, it should not. W-SUN is the canonical frequency
jaheba
approved these changes
Oct 11, 2022
lostella
added
bug fix
lostella
pushed a commit
to lostella/gluonts
that referenced
this pull request
Oct 28, 2022
Merged
lostella
pushed a commit
to lostella/gluonts
that referenced
this pull request
Oct 28, 2022
Merged
lostella
added a commit
that referenced
this pull request
Oct 28, 2022
* Fix numerical bug in `BinnedUniforms` (#2344) prob.cumsum() - prob is a numerically unsafe way to shift prob.cumsum() to the right. The numerical error will create small gaps or overlaps in the bins defined by lower and upper bounds. If a quantile falls in one of these overlap or gap the one hot bin indicator will have 0 or 2 hot bins and generate a shape mismatch error. The fix consists of doing a shift by copy. * Fix dominick dataset bug. (#2364) * Proposed fix to zero seed bug. (#2379) Co-authored-by: Sigrid Passano Hellan <[email protected]> Co-authored-by: Marc van Oudheusden <[email protected]> Co-authored-by: Bhaskar Dhariyal <[email protected]> Co-authored-by: Sigrid Passano Hellan <[email protected]> Co-authored-by: Sigrid Passano Hellan <[email protected]>
lostella
added a commit
that referenced
this pull request
Oct 28, 2022
* Fix dominick dataset bug. (#2364) * Remove strange quoting marks from docstrings (#2368) * Change 'confidence interval' to 'prediction interval' (#2373) * Proposed fix to zero seed bug. (#2379) Co-authored-by: Sigrid Passano Hellan <[email protected]> Co-authored-by: Bhaskar Dhariyal <[email protected]> Co-authored-by: Nils Kiele <[email protected]> Co-authored-by: Sigrid Passano Hellan <[email protected]> Co-authored-by: Sigrid Passano Hellan <[email protected]>
lostella
removed
pending v0.10.x backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2355
Description of changes:
changed to "W" to "W-SUN"
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup