Fixed backtest test. #235
Merged
Fixed backtest test. #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaheba
force-pushed
the
fix-backtest-test
branch
from
4bc17c2 to
ee83fef
Compare
jaheba
force-pushed
the
fix-backtest-test
branch
from
ee83fef to
77ae46d
Compare
lovvge
approved these changes
Aug 12, 2019
|
Job PR-235/3 is complete. |
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
==========================================
- Coverage 81.25% 81.19% -0.07%
==========================================
Files 130 130
Lines 7395 7392 -3
==========================================
- Hits 6009 6002 -7
- Misses 1386 1390 +4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test implied that we wanted to test the output of
backtest_metrics. However, we relied on an already checked-in file, which was never changed.Also, I've removed the
__str__method onDatasetStatisticssince we otherwise can't evaluate the output.