Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Setup typedoc to build references.json and configure release workflow to update docs site #14255

Merged
merged 15 commits into from
Mar 19, 2025

Conversation

stocaaro
Copy link
Member

@stocaaro stocaaro commented Feb 27, 2025

Description of changes

Automate the regeneration of the docs site references with each release.

Description of how you validated changes

I ran a truncated process on my work to demonstrate it works: https://github.com/stocaaro/amplify-js/actions/runs/13843396723, which results in this PR being generated on my fork stocaaro/docs#10

Checklist

  • PR description included
  • yarn test passes

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@stocaaro stocaaro changed the title chore: Configure typedoc chore: Setup typedoc to build references.json and configure release workflow to update docs site Mar 4, 2025
Copy link
Member

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflow looks good to me. But have some questions with the typedoc config change.

typedoc.json Outdated
"packages/aws-amplify/storage",
"packages/aws-amplify/storage/server",
"packages/aws-amplify/utils",
"packages/core",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason this line will cause our API reference page: https://aws-amplify.github.io/amplify-js/api/ to show the internal package @aws-amplify/core.

I'm thinking of using a separate typedoc config to generate reference.json that includes every thing doc side needs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migrated to using a different configuration file for the reference.json file.

@stocaaro stocaaro marked this pull request as ready for review March 13, 2025 19:59
@stocaaro stocaaro requested review from a team as code owners March 13, 2025 19:59
@joon-won
Copy link
Member

Looks good to me

@stocaaro stocaaro merged commit bbbfe2e into main Mar 19, 2025
30 checks passed
@stocaaro stocaaro deleted the stocaaro/configure-typedoc/main branch March 19, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants