fix(adapter-nextjs): server-side sign out not working with Firefox and Safari #14246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshfang
reviewed
Feb 25, 2025
Comment on lines
+73
to
+78
| extends AuthApiRequestHandlerInputBase { | ||
| request: Request; | ||
| handlerInput: CreateAuthRoutesHandlersInput; | ||
| } | ||
| interface HandleSignOutCallbackRequestForPagesHandlerInput | ||
| extends Omit<AuthApiRequestHandlerInputBase, 'origin'> { | ||
| extends AuthApiRequestHandlerInputBase { |
There was a problem hiding this comment.
Would this break anything? Although I don't know if anything can be done about it anyway if origin is needed even if it were
There was a problem hiding this comment.
This is a internal only function interface.
| ); | ||
|
|
||
| return new Response( | ||
| createOnSignInCompleteRedirectIntermediate({ |
There was a problem hiding this comment.
Is it confusing to create a "signInComplete..."? Maybe the function should be renamed to createRedirectionIntermediary or something?
There was a problem hiding this comment.
Oh yes, I meant to change the function name, will update.
packages/adapter-nextjs/src/auth/handleAuthApiRouteRequestForAppRouter.ts
Show resolved
Hide resolved
packages/adapter-nextjs/src/auth/handlers/handleSignOutCallbackRequestForPagesRouter.ts
Outdated
Show resolved
Hide resolved
packages/adapter-nextjs/src/auth/utils/createRedirectionIntermediary.ts
Outdated
Show resolved
Hide resolved
AllanZhengYP
approved these changes
Feb 25, 2025
cshfang
approved these changes
Feb 25, 2025
blakedunson
approved these changes
Feb 25, 2025
jjarvisp
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When Amazon Cognito
/logoutendpoint redirects back to the/sign-out-callbackroute the first time, let the handler sends client a 200 response with a intermediate page containing a redirect action to redirect to/sign-out-callbackagain to ensure the token cookies to be sent to the Next.js server so the sign-out process can complete correctly.Details see corresponding in-code comments.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.