Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gradle Resource Detection #86

Merged
merged 7 commits into from
Oct 28, 2024
Merged

Fix Gradle Resource Detection #86

merged 7 commits into from
Oct 28, 2024

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Oct 25, 2024 •
edited
Loading

What a rookie mistake.

  • now correctly detects the gradle build folder
  • now can detect if gradle is in the test-compile phase

Checklist before merge

Have these changes been tested with the below to confirm no negative interactions?

  • avaje-inject
  • avaje-jsonb
  • avaje-validator
  • avaje-spi-service

@SentryMan SentryMan added the bug Something isn't working label Oct 25, 2024
@SentryMan SentryMan self-assigned this Oct 25, 2024
@SentryMan
Copy link
Collaborator Author

@rbygrave please review and deploy when you get time

@SentryMan SentryMan mentioned this pull request Oct 25, 2024
Merged
@rbygrave rbygrave merged commit 11b0559 into avaje:main Oct 28, 2024
4 checks passed
@rbygrave rbygrave added this to the 1.33 milestone Oct 28, 2024
@SentryMan SentryMan deleted the fix-gradle-resource-detection branch October 30, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbygrave rbygrave rbygrave approved these changes

Assignees

@SentryMan SentryMan

Labels
bug Something isn't working
Projects
None yet
Milestone
1.33
Development

Successfully merging this pull request may close these issues.
2 participants
@SentryMan @rbygrave