Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Incorrect Comment Handling #84

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Sep 19, 2024

Now strips comments before parsing the module-info data

Fixes #83

Checklist before merge

Have these changes been tested with the below to confirm no negative interactions?

  • avaje-inject
  • avaje-jsonb
  • avaje-validator
  • avaje-spi-service

@SentryMan SentryMan added the bug Something isn't working label Sep 19, 2024
@SentryMan SentryMan self-assigned this Sep 19, 2024
@SentryMan
Copy link
Collaborator Author

hmm, it seems I need to tune this multiline regex

@SentryMan
Copy link
Collaborator Author

@rbygrave please review and deploy when you get time

@rbygrave rbygrave merged commit 65197bf into avaje:main Sep 20, 2024
4 checks passed
@SentryMan SentryMan deleted the fix-comments branch September 20, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong treatment of commented lines in module-info.java by ModuleInfoReader
2 participants