Move DynamicMemory to shale #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexfusion
requested review from
exdx,
xinifinity,
gyuho,
rkuris,
patrick-ogrady and
StephenButtolph
as code owners
hexfusion
force-pushed
the
hexfusion/dynamic
branch
3 times, most recently
from
ca13662 to
249d616
Compare
rkuris
approved these changes
Apr 19, 2023
hexfusion
force-pushed
the
hexfusion/dynamic
branch
from
249d616 to
8537a84
Compare
Signed-off-by: Sam Batschelet <[email protected]>
hexfusion
force-pushed
the
hexfusion/dynamic
branch
from
8537a84 to
b09a658
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
DynamicMeminto the shale library. It makes more sense to have this impl in the same lib asPlainMemvs a separate mod in firewood. This PR is part of a larger series of tests for shale.