Redefine Revision and View #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redefine `Revision` to only refer to previously commited (historical) point-in-time states/versions. Also clarify that the term View just refers to an interface used on revisions or proposals.
richardpringle
approved these changes
Jul 19, 2023
| * `Revision` - A historical point-in-time state/version of the trie. This | ||
| represents the entire trie, including all `Key`/`Value`s at that point | ||
| in time, and all `Node`s. | ||
| * `View` - This is the interface to read from a `Revision` or a `Proposal`. |
There was a problem hiding this comment.
🙌
Question, does the DB itself implement View? Or do you always need to get the latest revision?
There was a problem hiding this comment.
The DB object does not implement the View interface. Why not? Because that View would not be a constant point-in-time thing -- it would change as commits happen. You would be violating the new definition: a View reading from a Revision must be a historical point-in-time, not something that keeps changing as commits happen, which is what the DB object is.
There was a problem hiding this comment.
🤔 What methods exist on a View that don't exist on the Db itself?
xinifinity
approved these changes
Jul 20, 2023
|
Db is not defined but I suspect it is the collection of known revisions.
You can't have a view of that, only of a specific revision.
…On Thu, Jul 20, 2023, 12:59 Richard Pringle ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In README.md
<#160 (comment)>:
> @@ -58,9 +58,10 @@ upstream.
## Termimology
-* `Revision` - A point-in-time state/version of the trie. This represents the entire
- trie, including all `Key`/`Value`s at that point in time, and all `Node`s.
-* `View` - This is a synonym for a `Revision`.
+* `Revision` - A historical point-in-time state/version of the trie. This
+ represents the entire trie, including all `Key`/`Value`s at that point
+ in time, and all `Node`s.
+* `View` - This is the interface to read from a `Revision` or a `Proposal`.
🤔 What methods exist on a View that don't exist on the Db itself?
—
Reply to this email directly, view it on GitHub
<#160 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYLR3CDH3OMXXZY3DRDYSTXRGEZNANCNFSM6AAAAAA2QMWB5I>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
rkuris
added a commit
that referenced
this pull request
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redefine
Revisionto only refer to previously commited (historical) point-in-time states/versions. Also clarify that the term View just refers to an interface used on revisions or proposals.