Add default branch caching #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardpringle
force-pushed
the
test-cache
branch
from
5294484 to
28d2e1e
Compare
richardpringle
force-pushed
the
test-cache
branch
from
28d2e1e to
f25f95a
Compare
richardpringle
force-pushed
the
test-cache
branch
from
f25f95a to
6f3b880
Compare
richardpringle
force-pushed
the
test-cache
branch
from
6bd91d3 to
eca6109
Compare
xinifinity
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While individual branch caching is useful, it still doesn't get a speed up for new PRs. The only branch that shares its caches with all other branches is the default branch. So, this PR adds cache creation on every commit that gets merged to master. This should cut build times in half for new branches.
There are still some other optimizations that we can get related to crates, but I'm not sure it's worth spending the time on that now.
Edit:
I also realized that I'm creating two caches per PR. I've changed this to only create one