Unwind some growth-ring test nesting #109
Conversation
| @@ -106,7 +106,7 @@ pub struct WalRingId { | |||
| } | |||
|
|
|||
| impl WalRingId { | |||
| pub fn empty_id() -> Self { | |||
| pub const fn empty_id() -> Self { | |||
| } | ||
| }; | ||
| if let Some(canvas0) = canvas0 { | ||
| let start_ops = if last_idx > 0 { &ops[..last_idx] } else { &[] }; |
There was a problem hiding this comment.
🍹 much cleaner, I can see that this code really bugged you LOL
| let mut state = state.clone(); | ||
| let mut state0 = state.clone(); | ||
| let nticks = sim.get_nticks(&mut state0); | ||
| println!("fail = {}, nticks = {}", f, nticks); |
There was a problem hiding this comment.
| println!("fail = {}, nticks = {}", f, nticks); | |
| println!("fail = {f}, nticks = {nticks}"); |
There was a problem hiding this comment.
When do we get to turn on clippy::pedantic so it will tell me to do this?
| println!("fail = {}, nticks = {}", f, nticks); | ||
|
|
||
| for i in 0..nticks { | ||
| println!("fail = {}, pos = {}", f, i); |
There was a problem hiding this comment.
nit: i here is pos? Lets call this pos instead of i then.
| { | ||
| ); | ||
|
|
||
| if let Ok(_) = sim_result { |
There was a problem hiding this comment.
| if let Ok(_) = sim_result { | |
| if sim_result.is_ok() { |
Probably the only good time to use is_ok() is this case.
| if sims.len() > 1 { | ||
| _multi_point_failure(&sims[1..], &state, f + 1) | ||
| track_recursion(&sims[1..], &state, f + 1) |
There was a problem hiding this comment.
nit: I found this inner function call a little hard to read and understand, but I think it's okay.
There was a problem hiding this comment.
IMO, the inner function is better than fn name(args) { _name(args, 1) }... but I agree that it's bad. I'm going to leave it as is for now.
The better solution would be to just call the check method multiple times (I think), as there's only one case with two sims. But 🤷, I didn't fully try to understand what's happening, just tried to match the behaviour.
richardpringle
force-pushed
the
remove-labelled-break
branch
from
296bf63 to
83ec583
Compare
richardpringle
force-pushed
the
remove-labelled-break
branch
from
83ec583 to
19a51ee
Compare
Some simple clean ups