Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

META-2743: Changes to set Atlas Classification as RangerTags from Atlas authorizor for tag based authorization. #7

Open
wants to merge 2 commits into
base: atlas-changes
Choose a base branch
from

Conversation

nixon-atlan
Copy link

Change description

Changes to set Atlas Classification as RangerTags from Atlas authorizor for tag based authorization.

Description here

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@nixon-atlan nixon-atlan changed the title Changes to set Atlas Classification as RangerTags from Atlas authorizor for tag based authorization. META-2743: Changes to set Atlas Classification as RangerTags from Atlas authorizor for tag based authorization. Nov 29, 2021
Copy link
Member

@mukcool mukcool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukcool
Copy link
Member

mukcool commented Nov 30, 2021

@nixon-atlan we should also base the PR to base branch, and remove unnecessary commits -- health of tagsync / tagsync and mappers -- we do not need anymore

@nixon-atlan
Copy link
Author

Comments : https://atlanhq.slack.com/archives/C02CS1YQMFU/p1638161904377600
Code Refactoring , separate out the fetching classification from context into method -done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants