Custom section name in user readme #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilyx
changed the title
|
Hey, actually marked it as WIP and then edited it out - testing is done atm. |
|
@joe733 Squashed all the commits in one and updated readme :) |
yozachar
approved these changes
Nov 28, 2022
There was a problem hiding this comment.
Perfect! Thanks for the PR.
Note-to-self: Need input validation for
os.getenv("SECTION_NAME")
guilyx
force-pushed
the
master
branch
2 times, most recently
from
797f6a3 to
3406025
Compare
|
Hey again @joe733 |
|
Ah, thank you. But it was a |
yozachar
approved these changes
Nov 28, 2022
| @@ -58,6 +58,7 @@ | |||
| INPUT_REPOSITORY='<REPOSITORY SLUG>' | |||
| INPUT_COMMIT_MESSAGE='<COMMIT MESSAGE>' | |||
| INPUT_SHOW_TITLE='True' | |||
| INPUT_SECTION_NAME='wakacustom' | |||
There was a problem hiding this comment.
Keep, it as waka
-INPUT_SECTION_NAME='wakacustom'
+INPUT_SECTION_NAME='waka'| @@ -336,7 +342,7 @@ def churn(old_readme: str, /) -> str | None: | |||
| if not (waka_stats := fetch_stats()): | |||
| logger.error('Unable to fetch data, please rerun workflow') | |||
| sys.exit(1) | |||
|
|
|||
|
I do want to make changes, but for now let it be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, allow any other section name tag than "waka" in the readme, to avoid conflicts with other projects that may use the same default one. I'll do the same PR for the other one...
Currently testing.