Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove --renderer flag from asyncapi new template command #1739

Merged
merged 3 commits into from
Mar 20, 2025

Conversation

Adi-204
Copy link
Contributor

@Adi-204 Adi-204 commented Mar 20, 2025

Description
Remove --renderer flag from asyncapi new template command because only React engine is allowed nunjucks is deprecated.

Below is screenshot of working -

image

Related issue(s)
Fixes #1738

Copy link

changeset-bot bot commented Mar 20, 2025

🦋 Changeset detected

Latest commit: 0c871fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@asyncapi/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Adi-204
Copy link
Contributor Author

Adi-204 commented Mar 20, 2025

@Shurtu-gal can you please provide feedback any updates from my side thanks : )

Copy link
Collaborator

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shurtu-gal
Copy link
Collaborator

/rtm

@Shurtu-gal Shurtu-gal merged commit f0268d4 into asyncapi:master Mar 20, 2025
23 checks passed
AayushSaini101 added a commit to AayushSaini101/cli that referenced this pull request Apr 1, 2025
…capi#1739)

* feat: remove --renderer flag from asyncapi new template command

* Create breezy-pandas-arrive.md

* chore: update changesets

---------

Co-authored-by: Moderator <[email protected]>
Co-authored-by: Ashish Padhy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEATURE] Removal of --renderer flag from command asyncapi new template
4 participants