[red-knot] Goto type definition #16901
Draft
+1,073
−82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement Goto type definition support for Red Knot's LSP.
TODOs:
(
returns no results because it then finds theArguments
node instead of the object identifier. We likely need a tie-breaker function. r-a uses aTokenAtOffset
enum that returnsNone
,Single
orBetween
and then prioritizesBetween
. https://github.com/rust-analyzer/rowan/blob/e73210820dcd990b1b028d524efacbd619144fc3/src/api.rs#L213-L216Known limitations