Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FURB156] Do not consider docstring(s) #16391

Merged
merged 3 commits into from
Feb 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions crates/ruff_linter/resources/test/fixtures/refurb/FURB156.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,26 @@
# with comment
).capitalize()

# example with augmented assignment
_ += "0123456789"

# OK

_ = "1234567890"
_ = "1234"
_ = "12" in "12345670"


# No errors as the string is considered as a docstring
class C:
"01234567"


class C:
def method(self):
"01234567"


def function():
"""01234567"""

Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ impl AlwaysFixableViolation for HardcodedStringCharset {

/// FURB156
pub(crate) fn hardcoded_string_charset_literal(checker: &Checker, expr: &ExprStringLiteral) {
// if the string literal is a docstring, the rule is not applied
if checker.semantic().in_pep_257_docstring() {
return;
}

if let Some(charset) = check_charset_exact(expr.value.to_str().as_bytes()) {
push_diagnostic(checker, expr.range, charset);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -331,4 +331,30 @@ FURB156.py:26:5: FURB156 [*] Use of hardcoded string charset
27 |+ string.digits
27 28 | # with comment
28 29 | ).capitalize()
29 30 |
29 30 |

FURB156.py:31:6: FURB156 [*] Use of hardcoded string charset
|
30 | # example with augmented assignment
31 | _ += "0123456789"
| ^^^^^^^^^^^^ FURB156
32 |
33 | # OK
|
= help: Replace hardcoded charset with `string.digits`

ℹ Safe fix
1 1 | # Errors
2 |+import string
2 3 |
3 4 | _ = "0123456789"
4 5 | _ = "01234567"
--------------------------------------------------------------------------------
28 29 | ).capitalize()
29 30 |
30 31 | # example with augmented assignment
31 |-_ += "0123456789"
32 |+_ += string.digits
32 33 |
33 34 | # OK
34 35 |
Loading