Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github-actions): as ubuntu 20.04 is deprecated and will not be supported, this PR update ubuntu from 20.04 to 24.04 #16245

Closed

Conversation

Lee-W
Copy link
Contributor

@Lee-W Lee-W commented Feb 19, 2025

Summary

Replace ubuntu 20.04 with 24.04 as 20.04 has been deprecated and will soon be unsupported

actions/runner-images#11101

Test Plan

This PR does not change any rules

@dhruvmanila
Copy link
Member

Sorry if I wasn't clear in #16244, but release.yml is auto-generated and it will require cargo-dist to upgrade the Ubuntu version on their end (axodotdev/cargo-dist#1760) to update the release.yml file on our end.

@Lee-W Lee-W marked this pull request as draft February 19, 2025 06:42
@Lee-W
Copy link
Contributor Author

Lee-W commented Feb 19, 2025

Sorry if I wasn't clear in #16244, but release.yml is auto-generated and it will require cargo-dist to upgrade the Ubuntu version on their end (axodotdev/cargo-dist#1760) to update the release.yml file on our end.

ah, sorry, I did not notice this one... I'll make it draft and see what I can do on cargo-dist side

@Lee-W
Copy link
Contributor Author

Lee-W commented Feb 19, 2025

I took a look at the discussion. I guess it means we want to wait for their patch instead of using [github-custom-runners](https://opensource.axo.dev/cargo-dist/book/reference/config.html#github-custom-runners)?

@Lee-W Lee-W closed this Feb 19, 2025
@dhruvmanila
Copy link
Member

I took a look at the discussion. I guess it means we want to wait for their patch instead of using [github-custom-runners](https://opensource.axo.dev/cargo-dist/book/reference/config.html#github-custom-runners)?

Yes. I don't think using custom runners is the solution here as cargo-dist have acknowledged this and are going to switch, we just have to wait until then.

@Lee-W
Copy link
Contributor Author

Lee-W commented Feb 19, 2025

I took a look at the discussion. I guess it means we want to wait for their patch instead of using [github-custom-runners](https://opensource.axo.dev/cargo-dist/book/reference/config.html#github-custom-runners)?

Yes. I don't think using custom runners is the solution here as cargo-dist have acknowledged this and are going to switch, we just have to wait until then.

Agree. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants