[pep8-naming] Ignore @override methods (N803)
#15954
Merged
+161
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also #15296, which proposes that |
|
|
Would you mind taking a look at the ecosystem check. They all seem wrong because there are no I'd also be fine to ship this without preview because I consider it a bug fix. But I'm also okay to keep it behind preview. |
|
@MichaReiser This is due to the rule no longer checking lambdas. Fixed. |
MichaReiser
added
bug
MichaReiser
added a commit
that referenced
this pull request
Mar 13, 2025
…nvalid-argument-name`) (#16667) ## Summary This PR stabilizes the preview behavior for `invalid-argument-name` (`N803`) to ignore argument names of functions decorated with `typing.override` because these methods are *out of the authors* control. This behavior was introduced in #15954 and released as part of Ruff 0.9.5 (6th of February). There have been no new issues or PRs since this behavior change (preview) was introduced.
MichaReiser
added a commit
that referenced
this pull request
Mar 13, 2025
…nvalid-argument-name`) (#16667) ## Summary This PR stabilizes the preview behavior for `invalid-argument-name` (`N803`) to ignore argument names of functions decorated with `typing.override` because these methods are *out of the authors* control. This behavior was introduced in #15954 and released as part of Ruff 0.9.5 (6th of February). There have been no new issues or PRs since this behavior change (preview) was introduced.
MichaReiser
added a commit
that referenced
this pull request
Mar 13, 2025
…nvalid-argument-name`) (#16667) ## Summary This PR stabilizes the preview behavior for `invalid-argument-name` (`N803`) to ignore argument names of functions decorated with `typing.override` because these methods are *out of the authors* control. This behavior was introduced in #15954 and released as part of Ruff 0.9.5 (6th of February). There have been no new issues or PRs since this behavior change (preview) was introduced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #15925.
N803now checks for functions instead of parameters. In preview mode, if a method is decorated with@overrideand the current scope is that of a class, it will be ignored.Test Plan
cargo nextest runandcargo insta test.