[ruff] Add implementation for flake8-markupsafe via RUF035
#14224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| RUF035 | 51 | 51 | 0 | 0 | 0 |
sbrugman
reviewed
Nov 9, 2024
crates/ruff_linter/src/rules/flake8_markupsafe/rules/unsafe_markup_use.rs
Outdated
Show resolved
Hide resolved
sbrugman
reviewed
Nov 9, 2024
crates/ruff_linter/src/rules/flake8_markupsafe/rules/unsafe_markup_use.rs
Outdated
Show resolved
Hide resolved
sbrugman
reviewed
Nov 9, 2024
crates/ruff_linter/src/rules/flake8_markupsafe/rules/unsafe_markup_use.rs
Outdated
Show resolved
Hide resolved
sbrugman
reviewed
Nov 9, 2024
crates/ruff_linter/resources/test/fixtures/flake8_markupsafe/MS001.py
Outdated
Show resolved
Hide resolved
sbrugman
reviewed
Nov 9, 2024
crates/ruff_linter/src/rules/flake8_markupsafe/rules/unsafe_markup_use.rs
Outdated
Show resolved
Hide resolved
|
Nice contribution, thanks! |
Lifts fast check out of slow path. Adds additional test cases. Mentions i18n deviation in docstring.
sbrugman
reviewed
Nov 9, 2024
crates/ruff_linter/src/rules/flake8_markupsafe/rules/unsafe_markup_use.rs
Outdated
Show resolved
Hide resolved
sbrugman
reviewed
Nov 9, 2024
crates/ruff_linter/resources/test/fixtures/flake8_markupsafe/MS001.py
Outdated
Show resolved
Hide resolved
MichaReiser
added
rule
MichaReiser
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
This looks good to me. Thank you. The only change I would make is that I don't think it's worth introducing a new rule group for a single rule.
I'd also like to hear @AlexWaygood's opinion on the rule itself.
crates/ruff_linter/src/rules/flake8_markupsafe/rules/unsafe_markup_use.rs
Outdated
Show resolved
Hide resolved
…rkup_use.rs Co-authored-by: Micha Reiser <[email protected]>
AlexWaygood
reviewed
Nov 11, 2024
crates/ruff_linter/src/rules/flake8_markupsafe/rules/unsafe_markup_use.rs
Outdated
Show resolved
Hide resolved
AlexWaygood
reviewed
Nov 11, 2024
There was a problem hiding this comment.
I've never used markupsafe but it makes sense to me that this would be an important security consideration. I think it's good for linters to catch this.
Long-term, we should be able to improve the accuracy of rules like this when we switch to using red-knot as a backend (the LiteralString type is explicitly designed for this use case). But I don't think that should stop us from implementing this rule now!
Daverball
changed the title
dhruvmanila
changed the title
flake8-markupsafe] Add implementation for MS001 via RUF035
dhruvmanila
changed the title
flake8-markupsafe] Add implementation for MS001 via RUF035ruff] Add implementation for flake8-markupsafe via RUF035
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14124
Summary
This adds an implementation for flake8-markupsafe, minus the questionable exception for i18n and mako support, but with the ability to specify further aliases/subclasses/functionally equivalent for
markupsafe.Markup. By defaultflask.Markupis also detected as a commonly used alias.Test Plan
cargo nextest run