feat: added markers/ticks/labels and bg color for ranges #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing @stevedrew! This addition looks amazing. I will go through it soon! |
|
@ashish-chopra Hello! Will you merge this branch to master? I really need this functionality for my project. |
|
Yup, it's a long pending. I will try to do it over the weekend. Cheers! |
|
@ashish-chopra, Thank you very match! Cheers! |
|
@ashish-chopra, hello! Any status update here? |
|
@ashish-chopra hi, any updates on this issue? |
|
@ashish-chopra hi, appreciate a lot for merging, can u also update the npm package? thanks! |
|
v5.0.0 has been published. Thank you everyone for contributing and I apologize for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for a great widget...
I have added additional input parameters to allow markers/ticks with optional labels, font specifications. As well added margin param (needed if labels involved) and bgOpacity property to the thresholds which if specified uses the threshold color with the applied opacity to form the background color for the range.
See below for results: