Feat(anta_runner): Add ANTA BGP neighbors reachability tests

[carl-baillargeon]

Change Summary

Add additional inputs to VerifyReachability to cover BGP neighbors with update source configured.

Also simplify the bgp_neighbors property logic.

Component(s) name

arista.avd.anta_runner

Proposed changes

See Change Summary.

How to test

---
- name: Run ANTA
  hosts: FABRIC
  connection: local
  gather_facts: false
  tasks:
    - name: Run ANTA on EOS devices
      import_role:
        name: arista.avd.anta_runner

ansible-playbook playbook/fabric-validate.yml

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5188
# Activate the virtual environment
source test-avd-pr-5188/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/carl-baillargeon/avd.git@anta/add_reachability_tests#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/carl-baillargeon/avd.git#/ansible_collections/arista/avd/,anta/add_reachability_tests --force
# Optional: Install AVD examples
cd test-avd-pr-5188
ansible-playbook arista.avd.install_examples

[danieltudares]

Successfully ran the test in the lab. Tested manually shutting down some random interfaces and the report came back with a proper response pointing at failed BGP peering in idle state. After restoring the interfaces the report came back with all BGP tests passing.
LGTM!

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[carlbuchmann]

LGTM