-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_designs): Refactor eos_designs structured_config code for flows init #5123
Merged
ClausHolbechArista
merged 18 commits into
aristanetworks:devel
from
MaheshGSLAB:refactor-sflow
Mar 12, 2025
Merged
Refactor(eos_designs): Refactor eos_designs structured_config code for flows init #5123
ClausHolbechArista
merged 18 commits into
aristanetworks:devel
from
MaheshGSLAB:refactor-sflow
Mar 12, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5123
# Activate the virtual environment
source test-avd-pr-5123/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@refactor-sflow#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,refactor-sflow --force
# Optional: Install AVD examples
cd test-avd-pr-5123
ansible-playbook arista.avd.install_examples |
Vibhu-gslab
reviewed
Mar 5, 2025
python-avd/pyavd/_eos_designs/structured_config/flows/__init__.py
Outdated
Show resolved
Hide resolved
Vibhu-gslab
reviewed
Mar 5, 2025
python-avd/pyavd/_eos_designs/structured_config/flows/__init__.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/flows/__init__.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/flows/__init__.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/flows/__init__.py
Outdated
Show resolved
Hide resolved
laxmikantchintakindi
approved these changes
Mar 6, 2025
Vibhu-gslab
approved these changes
Mar 6, 2025
gmuloc
reviewed
Mar 6, 2025
python-avd/pyavd/_eos_designs/structured_config/flows/__init__.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/flows/__init__.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/flows/__init__.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/flows/__init__.py
Outdated
Show resolved
Hide resolved
ClausHolbechArista
requested changes
Mar 11, 2025
python-avd/pyavd/_eos_designs/structured_config/flows/__init__.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/flows/__init__.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/flows/__init__.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/flows/__init__.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/flows/__init__.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Claus Holbech <[email protected]>
Co-authored-by: Claus Holbech <[email protected]>
ClausHolbechArista
requested changes
Mar 12, 2025
...lecule/eos_designs_negative_unit_tests/inventory/host_vars/flow-tracking-missing-tracker.yml
Outdated
Show resolved
Hide resolved
...ta/avd/molecule/eos_designs_unit_tests/inventory/group_vars/FLOW_TRACKING_TESTS_SPINES_2.yml
Show resolved
Hide resolved
|
ClausHolbechArista
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Refactor eos_designs structured_config code for flow init
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_designs
Proposed changes
Refactor eos_designs structured_config code for flow init
How to test
Run molecule
Checklist
User Checklist
Repository Checklist