Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_designs): structured_config for underlay/mlag/inband_management Vlans #5051

Merged
merged 12 commits into from
Feb 27, 2025

Conversation

MaheshGSLAB
Copy link
Contributor

Change Summary

Refactor(eos_designs): structured_config for underlay Vlans

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_designs

Proposed changes

Refactor(eos_designs): structured_config for underlay Vlans

How to test

Run Molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@MaheshGSLAB MaheshGSLAB self-assigned this Feb 17, 2025
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5051
# Activate the virtual environment
source test-avd-pr-5051/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@vlans#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,vlans --force
# Optional: Install AVD examples
cd test-avd-pr-5051
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Feb 17, 2025
@MaheshGSLAB MaheshGSLAB changed the title Refactor(eos_designs): structured_config for underlay Vlans Refactor(eos_designs): structured_config for underlay/mlag/inband_management Vlans Feb 17, 2025
@github-actions github-actions bot removed the state: CI Updated CI scenario have been updated in the PR label Feb 17, 2025
@MaheshGSLAB MaheshGSLAB requested a review from gmuloc February 17, 2025 10:50
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review February 25, 2025 13:45
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners February 25, 2025 13:45
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Feb 27, 2025
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc merged commit 5afbf8e into aristanetworks:devel Feb 27, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(eos_designs)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants