Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add tls option for logging protocol #4914

Merged
merged 7 commits into from
Jan 23, 2025

Conversation

emilarista
Copy link
Contributor

Change Summary

Adds protocol option "tls" for logging.vrfs.host and ssl_profile to apply along with tls protocol option.

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

logging:
  vrfs:
    - name: <name>
      ...
      hosts:
        - name: <hostname>
           protocol: tls
           ssl_profile: <profile name>

How to test

Tested with molecule and on device.

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Sorry, something went wrong.

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4914
# Activate the virtual environment
source test-avd-pr-4914/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/emilarista/ansible-avd.git@logging-tls#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/emilarista/ansible-avd.git#/ansible_collections/arista/avd/,logging-tls --force
# Optional: Install AVD examples
cd test-avd-pr-4914
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jan 22, 2025
@emilarista emilarista marked this pull request as ready for review January 23, 2025 07:17
@emilarista emilarista requested review from a team as code owners January 23, 2025 07:17

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…ogging.schema.yml
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once pre-commit update the schema and doc

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the CI fix is needed

pre-commit-ci bot and others added 2 commits January 23, 2025 09:39
for more information, see https://pre-commit.ci

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@gmuloc gmuloc merged commit 420a757 into aristanetworks:devel Jan 23, 2025
45 checks passed
joelbreton2 pushed a commit to joelbreton2/avd that referenced this pull request Feb 12, 2025
…networks#4914)

Co-authored-by: Guillaume Mulocher <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants