-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add tls option for logging protocol #4914
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4914
# Activate the virtual environment
source test-avd-pr-4914/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/emilarista/ansible-avd.git@logging-tls#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/emilarista/ansible-avd.git#/ansible_collections/arista/avd/,logging-tls --force
# Optional: Install AVD examples
cd test-avd-pr-4914
ansible-playbook arista.avd.install_examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/logging.schema.yml
Outdated
Show resolved
Hide resolved
…ogging.schema.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once pre-commit update the schema and doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just the CI fix is needed
for more information, see https://pre-commit.ci
…networks#4914) Co-authored-by: Guillaume Mulocher <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Change Summary
Adds protocol option "tls" for logging.vrfs.host and ssl_profile to apply along with tls protocol option.
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
How to test
Tested with molecule and on device.
Repository Checklist