Feat(eos_cli_config_gen): Added outlier elimination feature support for AVT profile #4762
+404
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4762
# Activate the virtual environment
source test-avd-pr-4762/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-4240#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-4240 --force
# Optional: Install AVD examples
cd test-avd-pr-4762
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
...yavd/_eos_cli_config_gen/schema/schema_fragments/router_adaptive_virtual_topology.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-adaptive-virtual-topology.j2
Outdated
Show resolved
Hide resolved
MaheshGSLAB
requested review from
laxmikantchintakindi,
gmuloc and
ayushmittal-arista
Vibhu-gslab
force-pushed
the
issue-4240
branch
from
6259c87 to
10a45a8
Compare
Shivani-gslab
requested changes
Dec 5, 2024
...yavd/_eos_cli_config_gen/schema/schema_fragments/router_adaptive_virtual_topology.schema.yml
Show resolved
Hide resolved
...yavd/_eos_cli_config_gen/schema/schema_fragments/router_adaptive_virtual_topology.schema.yml
Show resolved
Hide resolved
...yavd/_eos_cli_config_gen/schema/schema_fragments/router_adaptive_virtual_topology.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-adaptive-virtual-topology.j2
Outdated
Show resolved
Hide resolved
...yavd/_eos_cli_config_gen/schema/schema_fragments/router_adaptive_virtual_topology.schema.yml
Outdated
Show resolved
Hide resolved
...yavd/_eos_cli_config_gen/schema/schema_fragments/router_adaptive_virtual_topology.schema.yml
Outdated
Show resolved
Hide resolved
...yavd/_eos_cli_config_gen/schema/schema_fragments/router_adaptive_virtual_topology.schema.yml
Outdated
Show resolved
Hide resolved
...yavd/_eos_cli_config_gen/schema/schema_fragments/router_adaptive_virtual_topology.schema.yml
Outdated
Show resolved
Hide resolved
...-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/router-adaptive-virtual-topology.j2
Outdated
Show resolved
Hide resolved
...-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/router-adaptive-virtual-topology.j2
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Shivani-gslab
force-pushed
the
issue-4240
branch
from
9503cdd to
9542329
Compare
laxmikantchintakindi
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Overall LGTM
just waiting for the confirmation here -#4762 (comment)
ClausHolbechArista
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Added outlier elimination feature support for AVT profile.
Related Issue(s)
Fixes #4240
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Added outlier elimination feature support for AVT profile.
How to test
Run the molecule and tox to check the coverage.
Checklist
User Checklist
Repository Checklist