-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add support for deadtime configuration to radius_server #4614
Feat(eos_cli_config_gen): Add support for deadtime configuration to radius_server #4614
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4614
# Activate the virtual environment
source test-avd-pr-4614/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@deadtime_radius_server#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,deadtime_radius_server --force
# Optional: Install AVD examples
cd test-avd-pr-4614
ansible-playbook arista.avd.install_examples |
44c49dd
to
0e6ffd1
Compare
0e6ffd1
to
59883e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking merge until 5.0.0 has been released.
5.0 is out so this can be reviewed and merged
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/radius_server.schema.yml
Outdated
Show resolved
Hide resolved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - can merge once CI completes
|
Change Summary
Add support for deadtime configuration to radius_server
Related Issue(s)
Fixes #4268
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
How to test
Molecule test or check the EOS CLI.
Checklist
User Checklist
Repository Checklist