Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add support for deadtime configuration to radius_server #4614

Merged
merged 7 commits into from
Nov 4, 2024

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Oct 18, 2024

Change Summary

Add support for deadtime configuration to radius_server

Related Issue(s)

Fixes #4268

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

radius_server:
      # Time in minutes to skip a non-responsive server.
      deadtime: <int; 1-1000>

How to test

Molecule test or check the EOS CLI.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4614
# Activate the virtual environment
source test-avd-pr-4614/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@deadtime_radius_server#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,deadtime_radius_server --force
# Optional: Install AVD examples
cd test-avd-pr-4614
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 18, 2024
@Shivani-gslab Shivani-gslab force-pushed the deadtime_radius_server branch from 44c49dd to 0e6ffd1 Compare October 18, 2024 12:32
@Shivani-gslab Shivani-gslab force-pushed the deadtime_radius_server branch from 0e6ffd1 to 59883e8 Compare October 18, 2024 12:35
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review October 21, 2024 09:01
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners October 21, 2024 09:01
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking merge until 5.0.0 has been released.

@ClausHolbechArista ClausHolbechArista dismissed their stale review October 28, 2024 08:14

5.0 is out so this can be reviewed and merged

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Oct 28, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Oct 30, 2024
@github-actions github-actions bot removed the state: conflict PR with conflict label Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - can merge once CI completes

Copy link

sonarqubecloud bot commented Nov 4, 2024

@gmuloc gmuloc merged commit 6cf63a0 into aristanetworks:devel Nov 4, 2024
45 checks passed
@Shivani-gslab Shivani-gslab deleted the deadtime_radius_server branch February 11, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deadtime configuration to radius_server
5 participants