WIP feat(APP-3895): Implement various UX improvements #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thekidnamedkd
changed the title
cgero-eth
reviewed
Mar 14, 2025
|
|
||
| const inputLabels = !hideLabels ? { label: name, helpText: notice } : undefined; | ||
| const formFieldName = proposalActionsDecoderUtils.getFieldName(fieldName, formPrefix); | ||
|
|
||
| const commonProps = { placeholder: type, className, ...inputLabels }; | ||
| const commonProps = { placeholder: '0x...', className, ...inputLabels }; |
There was a problem hiding this comment.
Couldn't find any mention to the fields placeholder on the Jira ticket, this component moreover is used for any transaction input and not just address types, so a 0x... placeholder would be wrong
There was a problem hiding this comment.
I interpreted that from below on ticket, but do agree that it's a bit tricky to extricate as the form/input relationship is fairly complex and we discussed at offsite that this has implications:
"When entering raw calldata for custom actions don’t pre-populate data with a value of “0x”. It should be placeholder text of “0x…”."
src/modules/components/proposal/proposalActions/proposalActionsItem/proposalActionsItem.tsx
Outdated
Show resolved
Hide resolved
tailwind.config.js
Outdated
| @@ -290,9 +290,6 @@ module.exports = { | |||
| }, | |||
| p: { | |||
| fontSize: theme('fontSize.base'), | |||
| '@screen md': { | |||
| fontSize: theme('fontSize.lg'), | |||
There was a problem hiding this comment.
Let's double check this with design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task: APP-3895
Type of change
Checklist:
CHANGELOG.mdfile after the [UPCOMING] title and before the latest version