Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): handle tracee pids correctly #4666

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented Mar 18, 2025

1. Explain what the PR does

a75e4a4 fix(tests): handle tracee pids correctly

Passing it as a single quoted variable fails when there are multiple
pids:
./tests/e2e-inst-test.sh: line 241: kill: 18731 19343: arguments must be process or job IDs

Handle it as an array instead so each pid element is expanded correctly.

2. Explain how to test it

3. Other comments

https://github.com/aquasecurity/tracee/actions/runs/13903229340/job/38899944478?pr=4583

Passing it as a single quoted variable fails when there are multiple
pids:
./tests/e2e-inst-test.sh: line 241: kill: 18731 19343: arguments must be process or job IDs

Handle it as an array instead so each pid element is expanded correctly.
Copy link
Contributor

@oshaked1 oshaked1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geyslan geyslan merged commit 48e848f into aquasecurity:main Mar 18, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants